Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withName method to GHCheckRunBuilder #1769

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Conversation

halkey
Copy link
Contributor

@halkey halkey commented Dec 5, 2023

…has been written.

Description

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@halkey
Copy link
Contributor Author

halkey commented Dec 5, 2023

Can you give me access to test repo please so that I can test my code.

@bitwiseman bitwiseman changed the title issue1587: withName method created in GHCheckRunBuilder and its test has been written Add withName method to GHCheckRunBuilder Dec 7, 2023
@bitwiseman
Copy link
Member

Invite sent.

@halkey
Copy link
Contributor Author

halkey commented Dec 13, 2023

can you check it again please

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b30e46) 80.44% compared to head (ad01b22) 80.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1769      +/-   ##
============================================
+ Coverage     80.44%   80.45%   +0.01%     
- Complexity     2316     2318       +2     
============================================
  Files           219      219              
  Lines          7026     7030       +4     
  Branches        371      371              
============================================
+ Hits           5652     5656       +4     
  Misses         1141     1141              
  Partials        233      233              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@halkey
Copy link
Contributor Author

halkey commented Dec 15, 2023

A new test is added to cover missing lines and javadoc is edited.

@halkey
Copy link
Contributor Author

halkey commented Dec 18, 2023

If you have any spare time, can you review it again please?

@bitwiseman bitwiseman merged commit 0f19519 into hub4j:main Feb 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants