Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to list workflow runs by head sha and created date #1789

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

gsmet
Copy link
Contributor

@gsmet gsmet commented Feb 9, 2024

Description

This adds additional parameters when looking for workflow runs i.e. head_sha and created. This is very useful when you want to check if some other workflow runs are running for the same head_sha.

See https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28#list-workflow-runs-for-a-repository for more context.

Partially fixes #1783 but I think the other parameters are a lot less useful (at least for now, I have no use of them, I could be convinced to add them if someone asks for them).

@bitwiseman I would highly appreciate if you had the time to push a release once this is in as I'm currently relying on snapshots, which is not ideal. Thanks a lot!

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be00e51) 80.64% compared to head (4433b11) 80.65%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1789      +/-   ##
============================================
+ Coverage     80.64%   80.65%   +0.01%     
- Complexity     2322     2324       +2     
============================================
  Files           219      219              
  Lines          7027     7031       +4     
  Branches        371      371              
============================================
+ Hits           5667     5671       +4     
  Misses         1128     1128              
  Partials        232      232              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwiseman bitwiseman merged commit 0af15ad into hub4j:main Feb 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing search parameters to GHWorkflowRunQueryBuilder
2 participants