[Patch 1/2] :: Add support to Marketplace endpoints #635
Conversation
PauloMigAlmeida
changed the title
|
@bitwiseman this PR is ready for your review :) |
|
@PauloMigAlmeida |
| @JsonProperty("organization_billing_email") | ||
| private String organizationBillingEmail; | ||
| private GHMarketplaceAccountType type; | ||
| @JsonProperty("marketplace_pending_change") |
There was a problem hiding this comment.
These should not be needed any more. I've updated the MAPPER:
https://github.com/github-api/github-api/blob/master/src/main/java/org/kohsuke/github/GitHub.java#L1401
| public class GHMarketplacePendingChange { | ||
| private GitHub root; | ||
| private long id; | ||
| @JsonProperty("unit_count") |
There was a problem hiding this comment.
| @JsonProperty("unit_count") |
| private Long unitCount; | ||
| @SuppressFBWarnings(value = "UWF_UNWRITTEN_FIELD", justification = "Field comes from JSON deserialization") | ||
| private GHMarketplacePlan plan; | ||
| @JsonProperty("effective_date") |
There was a problem hiding this comment.
| @JsonProperty("effective_date") |
|
|
||
| private GitHub root; | ||
| private String url; | ||
| @JsonProperty("accounts_url") |
There was a problem hiding this comment.
| @JsonProperty("accounts_url") |
And the same for most of the other JsonProperties here.
| * A Github Marketplace Account. | ||
| * | ||
| * @author Paulo Miguel Almeida | ||
| * @see GHMarketplaceListAccountBuilder#retrieve() |
There was a problem hiding this comment.
| * @see GHMarketplaceListAccountBuilder#retrieve() | |
| * @see GHMarketplaceListAccountBuilder#createRequest() |
Changed this in the GitHub class, should try to stay consistent.
|
|
||
| GHMarketplaceListAccountBuilder(GitHub root, long planId) { | ||
| this.root = root; | ||
| this.builder = new Requester(root); |
There was a problem hiding this comment.
| this.builder = new Requester(root); | |
| this.builder = root.createRequest(); |
There was a problem hiding this comment.
do you mean root.retrieve() ?
There was a problem hiding this comment.
nevermind :)
|
@bitwiseman sure! will do it tomorrow when I get home |
|
@bitwiseman changes implemented. Ready for your review :) |
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
bitwiseman
force-pushed
the
marketplace_endpoints
branch
from
fa2e3aa
to
c7123b0
Compare
Description
Add support to Marketplace endpoints
Endpoints added:
In the best interest of keeping this PR readable (too many lines due to the integration tests files), I will submit a second PR to add the remaining endpoints related to GitHub Marketplace.
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn install sitelocally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.