[Patch 2/2] :: Add support to Marketplace endpoints #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
…oses Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
…etplace_endpoints
…arketplace_endpoints
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
…meida/github-api into marketplace_endpoints_patch2 � Conflicts: � src/main/java/org/kohsuke/github/GHMarketplaceAccount.java � src/main/java/org/kohsuke/github/GHMarketplaceListAccountBuilder.java � src/test/java/org/kohsuke/github/GHMarketplacePlanTest.java
Signed-off-by: PauloMigAlmeida <paulo.miguel.almeida.rodenas@gmail.com>
|
@bitwiseman I implemented your suggestions on the patch 1 here as well. This PR is ready for your review |
bitwiseman
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the continuation of #635
Endpoint added:
PS.: I wasn't able to come up with a solution for the endpoint below given the way we currently handle non-4xx HTTP codes on this library. I do have a few ideas but I will create an issue so that we can discuss the available solutions before I implement it.
https://developer.github.com/v3/apps/marketplace/#check-if-a-github-account-is-associated-with-any-marketplace-listing
@bitwiseman let me know if you want me to change anything
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn install sitelocally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.