- bulk update of repository options

[jgangemi]

Description

allows bulk updating of repository settings instead of making individual calls for each.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

• Push your changes to a branch other than master. Create your PR from that branch.
• Add JavaDocs and other comments
• Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
• Run mvn clean compile locally. This may reformat your code, commit those changes.
• Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

• Fill in the "Description" above.
• Enable "Allow edits from maintainers".

[jgangemi]

any updates on getting this merged?

[jgangemi]

bueller? as someone who has contributed to this project before, it's super frustrating to do this work and then see the PR languish and other things merged ahead of it.

[jgangemi]

@bitwiseman hi! what needs to be done on my end to get some traction on this?

[bitwiseman]

@jgangemi
Sorry for delay, I was on leave. I've just cut a release, but that is not a comment on this change.

This is a solid, high-quality change. Thanks for including tests and javadoc. Great work!

I've invited you to the hub4j-test-org. Please join and rerecord test files using the org.

Also, as long as you're going to do this level of work, I'd be grateful if you would try implementing this using AbstractBuilder framework that I used in GHLabel. You'll end up with a little smaller set of changes and gain the use o the update()/set() batching behavior from AbstractBuilder. With the inheritance the way you have it now, I think what you have is pretty close already.

[bitwiseman]

Instead of having this be a parameter that gets passed down through the call stack, this should be a setting like mockGitHub.isUseProxy() but on AbstractGitHubWireMockTest, something like isTestWithUserAccount(). This will let users create, debug, and record tests using their account, but also easily turn it off and re-record from the test account later.

[jgangemi]

i feel like i followed this from some other example but i can see about addressing this.

[jgangemi]

@bitwiseman no worries. i'll take a look at what you suggested and get going on these changes.

[jgangemi]

@bitwiseman sorry for the delay on my end, changes made. let me know your feedback.

i set the default behavior to use the "org" to run tests and to set a property for a user account. i updated the contributing doc accordingly.