Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.2.6 #786

Merged
merged 5 commits into from
Sep 25, 2019
Merged

1.2.6 #786

merged 5 commits into from
Sep 25, 2019

Conversation

katat
Copy link
Contributor

@katat katat commented Sep 21, 2019 •
edited
Loading

  • Deprecate trimDecimals() and use NumericText component to format the numbers instead. (fix Error on hubii-core 1.2.5. #785)
  • Remove the pending settlement tx from local storage if it has been overridden by the other tx with the same nonce

@katat katat self-assigned this Sep 21, 2019
morfj
morfj reviewed Sep 21, 2019
View reviewed changes
Copy link

@morfj morfj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the numeric text component introduced?

@katat
Copy link
Contributor Author

katat commented Sep 22, 2019

@morfj
It is a UI component introduced earlier. https://github.com/hubiinetwork/hubii-core/blob/master/src/components/ui/NumericText/index.js

The function trimDecimals is currently doing the same formating work on top of the NumericText component. Deprecating the use of the trimDecimals will allow the values being formated by the NumbericText directly.

@katat katat requested a review from morfj September 22, 2019 01:47
@katat katat requested a review from jonbern September 24, 2019 08:40
jonbern
jonbern previously approved these changes Sep 24, 2019
View reviewed changes
@katat
Copy link
Contributor Author

katat commented Sep 25, 2019

@jonbern Sorry. There are some minor updates after your approval. Now it is ready for another review. Thanks.

@katat katat merged commit eca0654 into master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonbern jonbern jonbern approved these changes

@morfj morfj Awaiting requested review from morfj

Assignees

@katat katat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@katat @morfj @jonbern