Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdrawal stats in client fund smart contract #23

Closed
jijordre opened this issue Apr 24, 2018 · 1 comment
Closed

Withdrawal stats in client fund smart contract #23

jijordre opened this issue Apr 24, 2018 · 1 comment
Assignees
@mxmauro
Labels
enhancement
Projects
nahmii contracts
Milestone
v1

Comments

@jijordre
Copy link
Contributor

jijordre commented Apr 24, 2018 •
edited
Loading

Description

In client fund smart contract add functions Withdrawal(wallet: w, index: i) and WithdrawalCount(wallet: w). These are complementary to Deposit(wallet: w, index: i) and DepositCount(wallet: w).

Withdrawal(wallet: w, index: i) returns stats about withdrawal at index i from the staged balance of wallet w.

WithdrawalCount(wallet: w) returns the number of withdrawals by wallet w.

Definition of done

  • Client fund functions Withdrawal(wallet: w, index: i) and WithdrawalCount(wallet: w) are implemented
  • Unit tests for Withdrawal(wallet: w, index: i) and WithdrawalCount(wallet: w) are implemented

Details & Questions

This implementation is not included in the Omphalos specification.

Depends on
@jijordre jijordre added this to To do in nahmii contracts via automation Apr 24, 2018
@jijordre jijordre added this to the Priority 4 milestone Apr 24, 2018
mxmauro added a commit that referenced this issue Apr 25, 2018
@mxmauro
More tests and added methods of issue #23
34c943a
mxmauro added a commit that referenced this issue Apr 26, 2018
@mxmauro
Completed ClientFund before changes for settlement (#25)
e04163e 
* Whole code of ClientFund SC

* Some unit tests for ClientFund SC

* Added Unit test Helper SC

* Added more tests for ClientFunds

* Lots of unit tests added.

* More tests and added methods of issue #23

* Completed code before issue #24 major change.
@mxmauro
Copy link
Contributor

mxmauro commented Apr 26, 2018

Code added!

@mxmauro mxmauro closed this as completed Apr 26, 2018
nahmii contracts automation moved this from To do to Done Apr 26, 2018
@mxmauro mxmauro self-assigned this Apr 26, 2018
@jijordre jijordre modified the milestones: Priority 4, v1 Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxmauro mxmauro

Labels
enhancement
Projects
nahmii contracts
  
Done
Milestone
v1
Development

No branches or pull requests
2 participants
@mxmauro @jijordre