Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request hangs #134

Closed
hubiierik opened this issue Dec 17, 2019 · 2 comments
Closed

Request hangs #134

hubiierik opened this issue Dec 17, 2019 · 2 comments
Labels
escalating risk Non-functional issues identified to improve code quality
Projects

Comments

@hubiierik
Copy link
Contributor

When an request is issued to the Nahmii back-end,
it happens that the request hangs.

The internal feature NahmiiRequest is using super agent requests. The requests are made without timeout option.

Propose to add a timeout argument to the constructor of the NahmiRequests class.

@hubiierik hubiierik created this issue from a note in nahmii-sdk (Needs triage) Dec 17, 2019
@hubiierik hubiierik moved this from Needs triage to High priority in nahmii-sdk Dec 17, 2019
@hubiierik hubiierik added the escalating risk Non-functional issues identified to improve code quality label Dec 17, 2019
@hubiierik
Copy link
Contributor Author

Adding timeout to superagent works but there is a bug in superagent that impacts the way the timeout is reported.

Expected: ETIMEDOUT
Got: ABORTED

This means that unit tests must check for 'Abort' message at timeout instead of 'Response timeout'
The same issue also seems to have an impact on superagent retry feature where some claim that the retry feature does not work with superagent promise calls.

See: ladjs/superagent#1487

@hubiierik hubiierik moved this from High priority to In progress in nahmii-sdk Dec 18, 2019
@hubiierik
Copy link
Contributor Author

Done

nahmii-sdk automation moved this from In progress to Closed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
escalating risk Non-functional issues identified to improve code quality
Projects
nahmii-sdk
  
Closed
Development

No branches or pull requests

1 participant