Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CCFDatabase and API usage with HRA-API client #497

Closed
2 tasks done
bherr2 opened this issue Jun 26, 2024 · 2 comments · Fixed by #550
Closed
2 tasks done

Replace CCFDatabase and API usage with HRA-API client #497

bherr2 opened this issue Jun 26, 2024 · 2 comments · Fixed by #550
Labels
app: ccf-body-ui-wc Exploration User Interface: Body UI web component app: ccf-eui Exploration User Interface full application app: ccf-organ-info Exploration User Interface: Organ Info web component app: ccf-rui Registration User Interface
Milestone
Summer 2024 QoL I...

Comments

@bherr2
Copy link
Member

bherr2 commented Jun 26, 2024 •
edited by axdanbol
Loading

  • Replace all usage of CCFDatabase or the CCF-API client with the HRA-API Client: https://www.npmjs.com/package/@hra-api/ng-client
  • Find what is still needed from the ccf-database and work with Bruce to either save that function elsewhere or find an equivalent function via the HRA-API.
@bherr2 bherr2 added app: ccf-body-ui-wc Exploration User Interface: Body UI web component app: ccf-eui Exploration User Interface full application app: ccf-organ-info Exploration User Interface: Organ Info web component app: ccf-rui Registration User Interface labels Jun 26, 2024
@bherr2 bherr2 added this to the Summer 2024 QoL Improvements milestone Jun 26, 2024
@axdanbol axdanbol mentioned this issue Jul 11, 2024
Closed
@axdanbol
Copy link
Collaborator

axdanbol commented Jul 12, 2024 •
edited
Loading

Functions still in use:

  • getProbingSphereScene
  • getOriginScene
  • getTissueBlockScene

Remaining TODOs:

  • Refactor code to use interfaces from @hra-api/client instead of ccf-database

@bherr2
Copy link
Member Author

bherr2 commented Jul 13, 2024

Feel free to move those three functions to another dedicated library or possibly in the apps that use them. May be best to put it into a library.

@axdanbol axdanbol linked a pull request Jul 16, 2024 that will close this issue
Angular 18 upgrade #550
Merged
axdanbol added a commit that referenced this issue Jul 16, 2024
@axdanbol
refactor: Create ccf-scene-utils library
eb15d2d 
New location of functions from ccf-database that are still in use. See #497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app: ccf-body-ui-wc Exploration User Interface: Body UI web component app: ccf-eui Exploration User Interface full application app: ccf-organ-info Exploration User Interface: Organ Info web component app: ccf-rui Registration User Interface
Projects
None yet
Milestone
Summer 2024 QoL Improvements
Development

Successfully merging a pull request may close this issue.

Angular 18 upgrade hubmapconsortium/hra-ui
2 participants
@axdanbol @bherr2