New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assay_category: "Follow up with Chuck and see if it is even useful any longer" #873

Closed

mccalluc opened this issue Jun 11, 2021 · 1 comment

Assignees

Contributor

mccalluc commented Jun 11, 2021 •

edited

Loading

Right now they are being used for grouping on https://hubmapconsortium.github.io/ingest-validation-tools/
It is not used in any significant way in search-api or in portal-ui.
We could introduce a new version for every schema that drops this field.
I don't need to be, and would prefer not to be, a gatekeeper to schema changes: Anyone can make edits and regenerate the docs.
but if I am reviewing changes and they are inconsistent, I will raise a flag.

@khanshawPSC / @cebriggs7135 : Decide between yourselves what follow-up if any is required. Thanks!

mccalluc assigned cebriggs7135 and khanshawPSC

Contributor Author

mccalluc commented Jun 11, 2021

Conclusion seems to be that no action is needed? Reopen if needed.

After lengthy discussion at the June 11, 2021 Portal call, the decision made was to leave the assay_category as is. A group dedicated to assay_categories will revisit this in the future but leave as is for processing the new 3D IMC datasets.

Originally posted by @cebriggs7135 in hubmapconsortium/ingest-pipeline#338 (comment)

mccalluc closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment