-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mccalluc/serve notebooks #1873
Mccalluc/serve notebooks #1873
Conversation
@mccalluc There appears to be a bug in vitessce-python with |
We should also add some sort of validation for this to Vitessce, the schema is not strong enough, but may also not be the right place to do such validation |
And in Vitessce: vitessce/vitessce#952 |
Do you want to see this through to completion? Or would you prefer that it stay with me? |
Really do not know for sure, but I think that plan makes sense - do this PR then get feedback on the (functional) notebook output.
Indeed :(
No preference really - I think we have it separated for room for comments (check out some of the notebooks at https://vitessce.github.io/vitessce-python/ for reference)
I was thinking about this too - I think we can wait for Nils' feedback.
I do not have a preference, but the 3D stuff + ongoing bitmask/Cytokit work takes precedence due to the upcoming data releases so this could languish for a while if given to me. More likely though is that I just won't have the bandwidth to keep up with the back-and-forth feedback loop rather than the actual engineering. |
@ilan-gold : Following from the conversation at the meeting, I can make a branch that tries to add more explanation into the viewconf classes? I'm not at all sure that the experiment will be successful, but it's something I could do... and it would also let me get more familiarity with the view conf generation. So: Nothing for you to do right now. @keller-mark notes:
|
@ilan-gold -- Could you approve this much? After this, I would do a bit in assay_confs.py, and then vitessce-python. Exposing it in the UI would come last. (#1874) |
Please do request my review once you are ready with the |
Towards #1605. @ilan-gold , considered as a proof of concept, is this much reasonable? If it's easy for you, do you want to fill out the TODO with the rendering command? (This is syntactically valid, but I have not actually started up a kernel and tried to run it.)