Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives the issues api the ability to utilize request blocks #39

Merged
merged 3 commits into from
May 16, 2016

Conversation

discorick
Copy link
Member

@discorick discorick commented May 16, 2016

I.E

gh.issues(10) do |request|
  request.headers["Accept"] = "super-fancy/prevew-header"
end

@@ -7,7 +7,7 @@ Gem::Specification.new do |s|
s.version = Ghee::VERSION
s.authors = ["Ryan Rauh","Jonathan Hoyt"]
s.email = ["rauh.ryan@gmail.com"]
s.homepage = "http://github.com/rauhryan/ghee"
s.homepage = "http://github.com/huboard/ghee"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https

@drusellers
Copy link
Member

As a non-ruby dev - looks legit.

@dahlbyk
Copy link
Member

dahlbyk commented May 16, 2016

Are there any other proxies that can/should be made to accept blocks while we're here?

@discorick
Copy link
Member Author

Are there any other proxies that can/should be made to accept blocks while we're here?

Was hoping for minimal impact on this one. The answer is yes in probably quite a few places, can we defer to a larger ghee upgrade ? Theres also new endpoints and things we are going to want to implement.

@dahlbyk dahlbyk merged commit 68d6490 into master May 16, 2016
@dahlbyk dahlbyk deleted the discorick/enable_blocks_on_issue_api branch May 16, 2016 20:01
@dahlbyk
Copy link
Member

dahlbyk commented May 16, 2016

can we defer to a larger ghee upgrade ?

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants