Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubot pager schedule myschedule fails #67

Closed
ingardm opened this issue Nov 17, 2015 · 7 comments
Closed

hubot pager schedule myschedule fails #67

ingardm opened this issue Nov 17, 2015 · 7 comments

Comments

@ingardm
Copy link

ingardm commented Nov 17, 2015

The following error appears on the console:
[Tue Nov 17 2015 10:44:16 GMT+0100 (CET)] ERROR TypeError: undefined is not a function
at SlackBot.send (/home/ingard/src/chatops/hubot/node_modules/hubot-slack/src/slack.coffee:217:47, :265:19)
at Response.send (/home/ingard/src/chatops/hubot/node_modules/hubot/src/response.coffee:22:5, :20:47)
at /home/ingard/src/chatops/hubot/node_modules/hubot-pager-me/src/scripts/pagerduty.coffee:696:9, :786:17
at /home/ingard/src/chatops/hubot/node_modules/hubot-pager-me/src/scripts/pagerduty.coffee:689:7, :775:16
at /home/ingard/src/chatops/hubot/node_modules/hubot-pager-me/src/pagerduty.coffee:138:7, :185:16
at /home/ingard/src/chatops/hubot/node_modules/hubot-pager-me/src/pagerduty.coffee:46:9, :76:16
at IncomingMessage. (/home/ingard/src/chatops/hubot/node_modules/hubot-pager-me/node_modules/scoped-http-client/src/index.js:95:22)
at IncomingMessage.emit (events.js:129:20)
at _stream_readable.js:908:16
at process._tickCallback (node.js:355:11)

@stephenyeargin
Copy link
Member

Just to help debug, can you check which version of the package your Hubot is using? We have released several patches in the last few days.

@ingardm
Copy link
Author

ingardm commented Nov 17, 2015

hubot-pager-me@2.1.9 node_modules/hubot-pager-me

@stephenyeargin
Copy link
Member

Cool, that's the latest, so the bug must be in master. And was this your call to the bot?

User> hubot pager schedules

I know that @TheFynx and @mmrobins have been working with that particular call (and some related bugs), so I'm CC'ing them on this one.

@mmrobins
Copy link
Contributor

argh, took me awhile to reproduce since at first I was just testing with /.bin/hubot, but hit it quickly once I finally tried to upgrade my hubot to 2.1.9. It's because I left some debug output in that doesn't blow things up in console, but does in at least the slack adapter.

@ingardm
Copy link
Author

ingardm commented Nov 18, 2015

@stephenyeargin yes I did hubot: pager schedule mysched

@ingardm
Copy link
Author

ingardm commented Nov 18, 2015

I can confirm the fix mentioned by @mmrobins works for me also

stephenyeargin added a commit that referenced this issue Nov 18, 2015
Fix #67 matching schedules by removing debug output
@stephenyeargin
Copy link
Member

Fixed in v2.1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants