Added ability to optionally display video title #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenyeargin
approved these changes
Nov 28, 2020
davidscholberg
added a commit
to davidscholberg/chanspy
that referenced
this pull request
Nov 28, 2020
We can switch back to upstream now that hubot-archive/hubot-youtube#16 has been merged and pushed to npm.
|
Forgot to mention this released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to display the video titles along with the video URLs. This can be useful for adapters that don't have built-in URL preview functionality like IRC. Additionally, this PR adds the option to decode HTML entities from the returned titles. I have added new tests for this functionality.