Revert "Fix broken private messages, and increase code coverage" #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therealklanni any chance we can get this merged? |
ghost
reviewed
Oct 17, 2019
| return msg.sendPrivate(emit) | ||
| if (replyInPrivate && msg.message && msg.message.user && msg.message.user.name && msg.message.user.name !== msg.message.room) { | ||
| msg.reply('replied to you in private!') | ||
| return robot.send({ room: msg.message.user.name }, emit) |
There was a problem hiding this comment.
This should be msg.message.user.id not name.
|
Can you resolve the conflicts and make the suggested change RE: user id? If not, I can make another PR with the fix. |
|
Due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #44
sendPrivateis not part of the Hubot API, tests pass because it exists inhubot-test-helper.