New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix robot.respond bug which is occurred by unescaped robot.name #489

Merged
merged 1 commit into from May 1, 2013

Conversation

Projects
None yet
2 participants
@shiwano
Copy link
Contributor

shiwano commented Apr 27, 2013

Hello team.

I have found robot.respond bug which is occurred by unescaped robot.name.

http://www.ietf.org/rfc/rfc1459.txt
IRC nickname is allowed to use any regex reserved characters, so robot.name should be escaped. I want to make an IRC bot whom I named [^o^], but I can't it for this bug. 馃槬

Could you review it? Thanks.

tombell pushed a commit that referenced this pull request May 1, 2013

Tom Bell
Merge pull request #489 from shiwano/fix-respond-method
Fix robot.respond bug which is occurred by unescaped robot.name

@tombell tombell merged commit 957526c into hubotio:master May 1, 2013

@shiwano shiwano deleted the shiwano:fix-respond-method branch Jun 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment