Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear pool method #26

Merged
merged 60 commits into from
Aug 16, 2023
Merged

Linear pool method #26

merged 60 commits into from
Aug 16, 2023

Conversation

lshandross
Copy link
Contributor

No description provided.

@lshandross lshandross linked an issue Jul 25, 2023 that may be closed by this pull request
@lshandross lshandross force-pushed the linear_pool-method branch 2 times, most recently from 62598b3 to ff3ae41 Compare July 25, 2023 19:18
Copy link
Contributor

@elray1 elray1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For running unit tests, it may be necessary to modify the github workflow file to install dependencies. There is an example along these lines here.

R/linear_pool.R Outdated Show resolved Hide resolved
R/linear_pool.R Outdated Show resolved Hide resolved
R/linear_pool.R Outdated Show resolved Hide resolved
R/linear_pool.R Outdated Show resolved Hide resolved
R/linear_pool.R Outdated Show resolved Hide resolved
R/linear_pool.R Outdated Show resolved Hide resolved
R/linear_pool.R Outdated Show resolved Hide resolved
tests/testthat/test-linear_pool.R Outdated Show resolved Hide resolved
tests/testthat/test-linear_pool.R Outdated Show resolved Hide resolved
tests/testthat/test-linear_pool.R Outdated Show resolved Hide resolved
lshandross and others added 4 commits July 26, 2023 11:26
Co-authored-by: Evan Ray <elray1@users.noreply.github.com>
Co-authored-by: Evan Ray <elray1@users.noreply.github.com>
Co-authored-by: Evan Ray <elray1@users.noreply.github.com>
@lshandross lshandross force-pushed the linear_pool-method branch 5 times, most recently from 5b443ba to b8c5d71 Compare July 26, 2023 16:57
R/linear_pool.R Outdated Show resolved Hide resolved
Co-authored-by: Anna Krystalli <annakrystalli@googlemail.com>
Copy link
Contributor

@eahowerton eahowerton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small detail to check:
If I understand correctly, simple_ensemble() will only calculate the linear pool ensemble correctly for cdf and pmf when they are defined on the same output_type_id values for all models. I don't see a check included in validate_ensemble_inputs() for this, but perhaps it's being validated somewhere else (if so, apologies and please ignore this comment!)

@elray1
Copy link
Contributor

elray1 commented Aug 9, 2023

Thanks, Emily! You're right, we need to check that and we don't right now. We will add it :)

@elray1
Copy link
Contributor

elray1 commented Aug 10, 2023

Notes on how to do the validation Emily suggested:

  • Separate function that does this check, called from validate_ensemble_inputs
  • What this function validates:
    • Within each group defined by a combination of values for task id variables and output type, all models provided the same set of output type ids.
    • Check only applies to the cdf, pmf, and quantile output types. It is required for these types to ensure that the resulting distribution is valid (i.e., cdf values are increasing, pmf values sum to 1, and there is not quantile crossing). The check is not relevant to the mean, median, and sample types.

R/linear_pool.R Outdated Show resolved Hide resolved
Copy link
Contributor

@elray1 elray1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misc minor updates

R/linear_pool.R Outdated Show resolved Hide resolved
R/linear_pool.R Show resolved Hide resolved
R/linear_pool.R Outdated Show resolved Hide resolved
R/linear_pool.R Outdated Show resolved Hide resolved
R/linear_pool_quantile.R Outdated Show resolved Hide resolved
@elray1 elray1 merged commit 5f07beb into main Aug 16, 2023
5 checks passed
@elray1 elray1 deleted the linear_pool-method branch August 16, 2023 19:09
lshandross added a commit that referenced this pull request Feb 16, 2024
Initial version of a `linear_pool` function that works for mean, cdf, pmf, and quantile output types

---------
Co-authored-by: Anna Krystalli <annakrystalli@googlemail.com>
Co-authored-by: Evan Ray <elray@umass.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

linear_pool method
4 participants