-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linear pool method #26
Conversation
62598b3
to
ff3ae41
Compare
ff3ae41
to
3a4d45b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For running unit tests, it may be necessary to modify the github workflow file to install dependencies. There is an example along these lines here.
Co-authored-by: Evan Ray <elray1@users.noreply.github.com>
Co-authored-by: Evan Ray <elray1@users.noreply.github.com>
Co-authored-by: Evan Ray <elray1@users.noreply.github.com>
5b443ba
to
b8c5d71
Compare
b8c5d71
to
e911d80
Compare
Co-authored-by: Anna Krystalli <annakrystalli@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small detail to check:
If I understand correctly, simple_ensemble()
will only calculate the linear pool ensemble correctly for cdf
and pmf
when they are defined on the same output_type_id
values for all models. I don't see a check included in validate_ensemble_inputs()
for this, but perhaps it's being validated somewhere else (if so, apologies and please ignore this comment!)
Thanks, Emily! You're right, we need to check that and we don't right now. We will add it :) |
Notes on how to do the validation Emily suggested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misc minor updates
…d validate_output_type_ids
Initial version of a `linear_pool` function that works for mean, cdf, pmf, and quantile output types --------- Co-authored-by: Anna Krystalli <annakrystalli@googlemail.com> Co-authored-by: Evan Ray <elray@umass.edu>
No description provided.