Upgrade xUnit to 2.0.0 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our build system isn't ready for 2.1.0 yet.
Merged
| <package id="xunit.assert" version="2.0.0" targetFramework="net45" /> | ||
| <package id="xunit.core" version="2.0.0" targetFramework="net45" /> | ||
| <package id="xunit.extensibility.core" version="2.0.0" targetFramework="net45" /> | ||
| <package id="xunit.runner.visualstudio" version="2.0.0" targetFramework="net45" /> |
There was a problem hiding this comment.
I'm not as familiar with the Mjolnir tests, but should these also have xunit.runner.msbuild pulled in?
There was a problem hiding this comment.
The SystemTests don't need it (yet?) - they're more standalone and long-running and aren't kicked off by TeamCity. I've only run them manually from VisualStudio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would've jumped to 2.1.0, but ran into some issues with our internal build system and dependency management. Made the jump up to 2.0.0 anyway, it's a good first step.
Parallelism (introduced in xUnit 2) has been turned off in the assembly and msbuild directive. A number of test rely on static config state, and parallelism was causing those tests to fail. Let's revisit those tests in the future.