Allow for customizable instance IDs ... and a few fixes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convey panics when multiple test suites have the same name. See smartystreets/goconvey@52529b
InstanceMetadata.MarshalJSON must return proper JSON; i.e. an empty JSON object should be returned when Raw is not set. This fixes failing test case TestReregistration in net_test.go
Don't re-use instance between XML and JSON tests as InstanceMetadata.Raw does not seem to handle this at the moment.
|
Thanks for the contribution @st3v. This looks good to me. @tysonstewart or @llaughlin could I get another set of eyes on this before I merge? It shouldn't affect our usage of fargo since we don't currently set the |
|
@jcox92 I'll take a look at this before the end of the week. |
|
Looks good to me, 💯 |
itsrainy
pushed a commit
that referenced
this pull request
Sep 10, 2015
Allow for customizable instance IDs ... and a few fixes
|
Thanks for merging this! |
|
Definitely! Thanks for making fargo better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to add the ability to use custom instance IDs. This is needed in order to register multiple instances of the same app in a PAAS like Cloud Foundry. In such an environment the host name is the same for multiple instances of an app. Thus, using the host name as the instance ID will cause collisions in the registry. Beside the PAAS-case there are other use cases that require this feature, e.g. docker containers running on the same host.
This functionality has been added to the Java client a while ago, for details see Netflix/eureka#85.
The rest of the commits in this PR were needed to (a) get the Vagrant boxes up and running and (b) have all tests pass.
Let me know if you've got any questions. Thanks!