Simplify new bookings workflow #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some credit/debit filters in account statements. They had broken translations. This patch fixes the links to use symbols instead of strings and adds missing translation for all.
The accounts controller index action was using a manual `apply_scopes` call. This can be simplified by using the `collection` method provided by inherited_resources.
The current index action of the bookings controller simply called the `index!` action which implements the default behaviour for index actions. This patch drops the explicit declaration.
We did provide a two step work flow to create new bookings. The intention was to simplify booking by providing a way to use booking templates for quick booking. Providing booking templates is still a goal, but the previous implementation was complicating basic bookings. This patch drops the two steps to create bookings with a stock variant.
We once thought hiding some fields from the booking form would improve usability. We used that 'simplified' booking form when creating bookings from templates. But it built up technical dept and led to inconsistencies. This patch replaces the simplified booking form with the default one.
We were young and I loved to write code... So we did stuff more complicated than it needs to be:-) This commit refactors some controllers to use the default redirect style for actions.
There is actually a saldo of an account, but it bears different meaning dependent on context, type etc. Current implementation was misleading. Drop saldo column from account list.
It does not make sense to pass in a date range when opening accounts from the index. It should (and will) use a global date range though. This patch drops the by_date parameter in the links to account statements.
When we browse a list of bookings we often look for one with a specific receipt nr. That's how it is related to paper and thought of. This add the code column to all booking lists.
We have a regression in the in-line booking form in the lists. This patch disables the in-line form for now.
When searching for bookings in the journal one might also look for records in different years. The current fiscal year should be the default though. This patch uses the fiscal year period to seed the date filter.
The bookings list shows a pager when too many items exist. The number of records might change, so the pager also needs to be updated. This change includes the pager in the partial that gets rendered.
There was not enough right padding in the filter form, so we had visual glitches. This patch adds a `container-fluid` wrapping the `row-fluid` entries.
|
This actually grew into a collection of minor improvements, not just simplified booking forms. |
huerlisi
added a commit
that referenced
this pull request
Sep 3, 2015
Simplify new bookings workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did provide a two step work flow to create new bookings. The
intention was to simplify booking by providing a way to use booking
templates for quick booking. Providing booking templates is still a
goal, but the previous implementation was complicating basic bookings.
We once thought hiding some fields from the booking form would improve
usability. We used that 'simplified' booking form when creating bookings
from templates. But it built up technical dept and led to
inconsistencies.
Also includes some code simplifications and i18n fixes.