Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(huffup): Check if command exists before using it #257

Merged
merged 3 commits into from
Mar 12, 2023
Merged

fix(huffup): Check if command exists before using it #257

merged 3 commits into from
Mar 12, 2023

Conversation

lambda-0x
Copy link
Contributor

Overview

Only attempt to uninstall older huffc compiler if that specific package manager is installed.

Without this everytime i run huffup, i see:

~/.huff/bin/huffup: line 25: yarn: command not found

Maddiaa0
Maddiaa0 previously approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you!

@Maddiaa0 Maddiaa0 changed the base branch from main to stage March 12, 2023 07:35
@Maddiaa0 Maddiaa0 dismissed their stale review March 12, 2023 07:35

The base branch was changed.

Maddiaa0
Maddiaa0 approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapprove

@Maddiaa0 Maddiaa0 merged commit 03401a8 into huff-language:stage Mar 12, 2023
@Maddiaa0 Maddiaa0 mentioned this pull request Mar 12, 2023
Merged
@lambda-0x lambda-0x deleted the fix-huffup branch March 12, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maddiaa0 Maddiaa0 Maddiaa0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lambda-0x @Maddiaa0 @refcell