This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Dynamic constructor arguments (immutables) #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks good. i would like to get @clabby to review it before merge also beware: |
|
I will try to make some time quickly to do other tokens too. |
|
@MathisGD does it need tests? 🤔 |
|
I think that current ones already test this enough. Wdyt ? |
MathisGD
force-pushed
the
feat/dynamic-constructor-arguments
branch
2 times, most recently
from
6990315
to
90937e6
Compare
MathisGD
force-pushed
the
feat/dynamic-constructor-arguments
branch
from
90937e6
to
0a16203
Compare
|
Ready for review @devtooligan @clabby @refcell :-) |
MathisGD
commented
Feb 6, 2023
Closed
This was referenced Mar 20, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat #63
Inspired by https://github.com/MathisGD/huff-immutable