Refactor process executors to be in AcceleratorState #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Feb 3, 2023
| @@ -573,7 +558,7 @@ def main_process_first(self): | |||
| ... print(f"This will be printed by process {accelerator.process_index}") | |||
| ``` | |||
| """ | |||
| yield from self._goes_first(self.is_main_process) | |||
| yield self.state.main_process_first() | |||
There was a problem hiding this comment.
Shoudn't this be yield from?
There was a problem hiding this comment.
Using yield from actually will raise an error and using yield with the inner calling yield from is enough. I'll add a test with this first but the multi-GPU tests passed :)
sgugger
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on conversation in slack, refactors the logic for process executors to be handled in the
AcceleratorStateand delegated to theAcceleratorinstead of in theAcceleratoritself so that theStatecan be used by individuals that want to do process delegation without needing multipleAcceleratorobjects in their codebase.Still TODO is to move the decorators over, but those need some more improvements due to confusions in them and tests so that is a much later to-get-to