Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quality tools to 2023 #1046

Merged
merged 4 commits into from
Feb 7, 2023
Merged

Update quality tools to 2023 #1046

merged 4 commits into from
Feb 7, 2023

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Feb 7, 2023 •
edited

This PR updates the quality tools the same way as in Transformers by:

  • updating black to the 23 version
  • updating black target to python 3.7
  • removing flake8 and isort to use ruff instead
  • removing third parties entirely

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 7, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

muellerzr
muellerzr approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! :)

@sgugger sgugger merged commit 5002e56 into main Feb 7, 2023
@sgugger sgugger deleted the update_quality branch February 7, 2023 18:34
@akx akx mentioned this pull request Jan 31, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

@pacman100 pacman100 Awaiting requested review from pacman100

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgugger @HuggingFaceDocBuilderDev @muellerzr