Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update fsdp docs and removing deepspeed version pinning #1059

Merged
merged 2 commits into from
Feb 14, 2023
Merged

update fsdp docs and removing deepspeed version pinning #1059

merged 2 commits into from
Feb 14, 2023

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Adds docs on correct way to save FSDP models as per the resolution of issue All layer weights not getting saved when using accelerate + FSDP for OPT 2.7B #1054
  2. Removes deepspeed version pinning

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 13, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

muellerzr
muellerzr approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for docs update!

sgugger
sgugger approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

docs/source/usage_guides/fsdp.mdx Outdated Show resolved Hide resolved
@pacman100 pacman100 merged commit 0410309 into huggingface:main Feb 14, 2023
@pacman100 pacman100 deleted the smangrul/update-docs branch March 3, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacman100 @HuggingFaceDocBuilderDev @muellerzr @sgugger