Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor state and make PartialState first class citizen #1071

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

muellerzr
Copy link
Collaborator

Refactors the PartialState and Accelerator to have the core decorator process-logic happen inside PartialState and then upstreams it to AcceleratorState and Accelerator, as PartialState should act as the main processes controller for users if they choose not to use the Accelerator. As a result, PartialState has complete docs for the functions while the AcceleratorState does not. I can also make a note on the version in AcceleratorState to point this out to users potentially.

@muellerzr muellerzr added the enhancement New feature or request label Feb 14, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 14, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@muellerzr muellerzr merged commit 4e1816d into main Feb 14, 2023
@muellerzr muellerzr deleted the refactor-state branch February 14, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants