Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ops and fix reduce #1122

Merged
merged 7 commits into from
Feb 28, 2023
Merged

Add test for ops and fix reduce #1122

merged 7 commits into from
Feb 28, 2023

Conversation

muellerzr
Copy link
Collaborator

Closes #1112

Fixes reduce to actually perform the mean operation, and adds a testing suite to the multigpu and cpu testfiles (TPU is a TODO once we have a runner)

@muellerzr muellerzr added bug Something isn't working enhancement New feature or request labels Feb 27, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 27, 2023

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr removed the request for review from sgugger February 27, 2023 15:52
@muellerzr muellerzr marked this pull request as draft February 27, 2023 15:52
@muellerzr muellerzr marked this pull request as ready for review February 27, 2023 16:59
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing and testing!

@muellerzr muellerzr merged commit 0b3f219 into main Feb 28, 2023
@muellerzr muellerzr deleted the test-ops branch February 28, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mean reduce of distributed training not working
3 participants