Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually raise if exception #1124

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Actually raise if exception #1124

merged 1 commit into from
Feb 28, 2023

Conversation

muellerzr
Copy link
Collaborator

Closes #996

@muellerzr muellerzr added the bug Something isn't working label Feb 27, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 27, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muellerzr muellerzr merged commit ade4f1d into main Feb 28, 2023
@muellerzr muellerzr deleted the raise-err branch February 28, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

accelerate launch returns exit code 0 on error
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger