Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tee and role in Launch #1132

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Expose tee and role in Launch #1132

merged 1 commit into from
Mar 1, 2023

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented Mar 1, 2023

Adds --tee and --role to launch, once #1108 is closed a better method will be used that doesn't require us to redefine each arg like this (and it can be done dynamically).

Requested by @stas00

@muellerzr muellerzr added the enhancement New feature or request label Mar 1, 2023
@muellerzr muellerzr requested a review from sgugger March 1, 2023 15:54
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 1, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those!

Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested - all works - thanks a lot, Zach!

@muellerzr muellerzr merged commit e1b84bf into main Mar 1, 2023
@muellerzr muellerzr deleted the add-args branch March 1, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants