Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ds dist init kwargs issue #1138

Merged
merged 2 commits into from
Mar 2, 2023
Merged

fix ds dist init kwargs issue #1138

merged 2 commits into from
Mar 2, 2023

Conversation

pacman100
Copy link
Contributor

@pacman100 pacman100 commented Mar 2, 2023 •
edited by muellerzr

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 2, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

@pacman100 pacman100 requested a review from sgugger March 2, 2023 12:19
@pacman100 pacman100 marked this pull request as ready for review March 2, 2023 12:19
sgugger
sgugger reviewed Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the point of the test with DeepSpeed 0.6.5 if I may?

@pacman100
Copy link
Contributor Author

It was sort of hot fix for microsoft/DeepSpeed#2117. PR for it #544

sgugger
sgugger approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks!

@pacman100 pacman100 merged commit d88bbbd into huggingface:main Mar 2, 2023
@pacman100 pacman100 deleted the smangrul/ds-dist-init-fix branch March 3, 2023 13:54
@pacman100 pacman100 mentioned this pull request Mar 29, 2023
Closed
4 tasks
@abhilash1910 abhilash1910 mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] - AcceleratorState initialization in DS case ignores timeout argument
3 participants
@pacman100 @HuggingFaceDocBuilderDev @sgugger