Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated command directions and use in tests #1166

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Conversation

muellerzr
Copy link
Collaborator

Since torch.distributed.launch is deprecated, finds all cases of launch and replaces with run/torchrun

@muellerzr muellerzr added the documentation Improvements or additions to documentation label Mar 8, 2023
@muellerzr muellerzr requested a review from sgugger March 8, 2023 17:43
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 8, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In the examples we should mention that for older PyTorch versions, user should use torch.distributed.launch no?

@muellerzr
Copy link
Collaborator Author

@sgugger changed it to be:

    * With PyTorch launcher only (`torch.distributed.launch` can be used in older versions of PyTorch)
        ```bash
        python -m torchrun --nproc_per_node 2 \
            --use_env \
            --node_rank 0 \
            --master_addr master_node_ip_address \
            ./nlp_example.py  # On the first server
       ```

in the respective areas in the README.md

@muellerzr muellerzr merged commit abc2beb into main Mar 8, 2023
@muellerzr muellerzr deleted the outdated-command branch March 8, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants