[Accelerator] We should not call to on modules that wraps accelerate loaded models
#1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
younesbelkada
changed the title
Accelerator] We should to call to on modules that wrap accelerate loaded modelsAccelerator] We should not to call to on modules that wrap accelerate loaded models
younesbelkada
changed the title
Accelerator] We should not to call to on modules that wrap accelerate loaded modelsAccelerator] We should not to call to on modules that wraps accelerate loaded models
younesbelkada
changed the title
Accelerator] We should not to call to on modules that wraps accelerate loaded modelsAccelerator] We should not call to on modules that wraps accelerate loaded models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In some training setups such as in
trl: https://github.com/lvwerra/trl sometimes users create a new module that wraps modules that are loaded withaccelerate. Check for example this classI propose a simple fix in the accelerator to check if there is any immediate child module that has the
hf_device_mapattributecc @sgugger
I can confirm all slow tests pass except the similar ones as in #1155 - which I believe are related to the way I am creating my env