Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ds offload optim fix to use CPUAdam #1208

Merged
merged 2 commits into from Mar 20, 2023
Merged

ds offload optim fix to use CPUAdam #1208

merged 2 commits into from Mar 20, 2023

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Use DeepSpeedCPUAdam when offloading optimizer to CPU/NVME

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 18, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

@pacman100 pacman100 requested a review from sgugger March 18, 2023 11:15
@pacman100 pacman100 marked this pull request as ready for review March 18, 2023 11:16
sgugger
sgugger approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@pacman100 pacman100 merged commit 10c6746 into huggingface:main Mar 20, 2023
@pacman100 pacman100 deleted the smangrul/ds-offload-optim branch March 24, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pacman100 @HuggingFaceDocBuilderDev @sgugger