Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move when the GradientState test is performed so that it is not None #1219

Merged
merged 1 commit into from Mar 20, 2023
Merged

Move when the GradientState test is performed so that it is not None #1219

merged 1 commit into from Mar 20, 2023

Conversation

muellerzr
Copy link
Collaborator

Closes #1215

@muellerzr muellerzr added the bug Something isn't working label Mar 20, 2023
@muellerzr muellerzr requested a review from sgugger March 20, 2023 13:43
sgugger
sgugger approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 20, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr merged commit 7e7f344 into main Mar 20, 2023
@muellerzr muellerzr deleted the fix-tpu branch March 20, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'num_steps'
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger