Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove empty dicts while saving accelerate config #1236

Merged
merged 1 commit into from Mar 23, 2023
Merged

remove empty dicts while saving accelerate config #1236

merged 1 commit into from Mar 23, 2023

Conversation

pacman100
Copy link
Contributor

@pacman100 pacman100 commented Mar 23, 2023 •
edited

What does this PR do?

  1. Accelerate config is flooding with many empty dict fields as the number of integrations is increasing. This helps accelerate config to only contain the necessary config

@pacman100 pacman100 marked this pull request as ready for review March 23, 2023 07:43
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 23, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

muellerzr
muellerzr approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@pacman100 pacman100 merged commit ea9b854 into huggingface:main Mar 23, 2023
22 checks passed
@pacman100 pacman100 deleted the smangrul/minimal-accelerate-config branch March 24, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacman100 @HuggingFaceDocBuilderDev @muellerzr @sgugger