Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead go with evaluation_mode #1540

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Instead go with evaluation_mode #1540

merged 1 commit into from
Jun 7, 2023

Conversation

muellerzr
Copy link
Collaborator

Sets an evaluation_mode instead under prepare_model, that will let torch.compile remain as well.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 6, 2023 •
edited

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating!

pacman100
pacman100 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Zach for adding this! 🤗

@pacman100 pacman100 mentioned this pull request Jun 7, 2023
Merged
@muellerzr muellerzr merged commit 90e9703 into main Jun 7, 2023
24 checks passed
@muellerzr muellerzr deleted the further-mp branch June 7, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@muellerzr @HuggingFaceDocBuilderDev @pacman100 @sgugger