check port availability only in main deepspeed/torchrun launcher #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great @Jingru, can we also do this for the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Jingru
changed the title
Sure thing. Already updated. |
muellerzr
approved these changes
Oct 27, 2023
muellerzr
reviewed
Oct 27, 2023
Comment on lines
+131
to
+132
| need_port_check = num_machines <= 1 or int(args.machine_rank) == 0 | ||
| if need_port_check and is_port_in_use(main_process_port): |
There was a problem hiding this comment.
Just a small nit though thinking on this more, can we add a comment here just mentioning how/why we should only check on the main node for this, in case others want to learn why as well :)
There was a problem hiding this comment.
cc @Jingru :)
@muellerzr already add some comments
BenjaminBossan
approved these changes
Oct 27, 2023
add comments
|
comments added |
pacman100
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently,
main_process_portavailability is checked on all the deepspeed launchers (for multi_node senario), but this check is only necessary for main launcher whose machine rank is 0.Who can review?