Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit error if empty batch received #2115

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Add explicit error if empty batch received #2115

merged 2 commits into from
Nov 3, 2023

Conversation

YuryYakhno
Copy link
Contributor

Improve error message in find_batch_size() when dataset is empty

Add explicit error message in case of empty dictionary received. Details are in #2108.

Fixes #2108

@YuryYakhno YuryYakhno mentioned this pull request Nov 2, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

muellerzr
muellerzr reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very good! I think we can do better though. Let's check this as the first part in the func

src/accelerate/utils/operations.py Outdated Show resolved Hide resolved
muellerzr
muellerzr approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the more explicit error!

BenjaminBossan
BenjaminBossan approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@muellerzr muellerzr merged commit 4f10031 into huggingface:main Nov 3, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

@muellerzr muellerzr muellerzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message in find_batch_size()
4 participants
@YuryYakhno @HuggingFaceDocBuilderDev @BenjaminBossan @muellerzr