Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import error when torch>=2.0.1 and torch.distributed is disabled #2121

Merged

Conversation

natsukium
Copy link
Contributor

What does this PR do?

Fixes #1787 again

The full log of pytest is here.
https://gist.github.com/natsukium/385b7e405f8773d007f587d899ce5373

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sgugger who checked my former PR. But he left huggingface and does not seem to be active anymore.
@pacman100 who introduced the code related to this FSDP.

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @natsukium for the fix, LGTM!

@pacman100
Copy link
Contributor

cc @muellerzr for a second look before merging.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pacman100 pacman100 merged commit 76de60d into huggingface:main Nov 8, 2023
24 checks passed
@natsukium natsukium deleted the fix/fsdp-without-torch-distributed branch November 8, 2023 12:33
@natsukium
Copy link
Contributor Author

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot import accelerate when torch>=2.0.1 and torch.distributed is disabled
4 participants