Allow for ACCELERATE_SEED env var #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
5 tasks
BenjaminBossan
approved these changes
Nov 7, 2023
src/accelerate/utils/random.py
Outdated
| @@ -30,7 +31,8 @@ | |||
|
|
|||
| def set_seed(seed: int, device_specific: bool = False): | |||
| """ | |||
| Helper function for reproducible behavior to set the seed in `random`, `numpy`, `torch`. | |||
| Helper function for reproducible behavior to set the seed in `random`, `numpy`, `torch`. Also will set the random | |||
| seed for `SeedableRandomSampler` through the `ACCELERATE_SEED` environment variable. | |||
There was a problem hiding this comment.
Similar comment to the one above: Users don't really care about SeedableRandomSampler, as this is an implementation detail of accelerate. They will care more about knowing when this function needs to be used.
BenjaminBossan
approved these changes
Nov 7, 2023
|
@BenjaminBossan yep! set_seed, and in the Trainer just having it set the torch seed will be enough for general users |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces
ACCELERATE_SEEDas part ofset_seed. Doing so will allow for the custom random samplers to rely on it for setting the seed, rather than the generator (as this can lead to imperfect issues). Solves related trainer test failures.Fixes # (issue)
Internal slack thread
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@LysandreJik @BenjaminBossan