Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pypi for merge workflows + fix trainer tests #2153

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented Nov 14, 2023

What does this PR do?

Disables the pypi release tests for merge and PR CI's. Unnecessary feedback and should reduce main CI time by ~10min and uninstalls trackers to fix the issues with the transformers tests

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 14, 2023

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr changed the title Disable pypi for merge workflows Disable pypi for merge workflows + fix trainer tests Nov 15, 2023
@muellerzr
Copy link
Collaborator Author

CI running to check this: Integration Tests (push to "main")

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just to be sure, did we ever encountered a situation were the tests were failing on pypi but not on the main branch of transformers ? If that's not the case, it makes sense to disable pypi.

@muellerzr
Copy link
Collaborator Author

@SunMarc yes, because a fix was put into the main in transformers and then propagated once the next release came out. This CI will still run on pypi for releases + nightly, but we don't need that level of feedback on main

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, thanks for making the change. Just for my understanding, what is the issue with the trackers?

@muellerzr
Copy link
Collaborator Author

@BenjaminBossan unrelated test failures due to comet-ml not liking how certain things are setup, and the examples tests pull them all in automatically. Rather than dealing with faking the trackers/mocks/etc etc on the transformers side just uninstall them so as to not worry about it

@muellerzr muellerzr merged commit 0f2686c into main Nov 15, 2023
28 checks passed
@muellerzr muellerzr deleted the disable-for-merge branch November 15, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants