Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
torch-native pipeline parallelism for big models #2345
torch-native pipeline parallelism for big models #2345
Changes from 3 commits
e713e28
2767bb1
06f04a9
9eef9dd
449eb8d
77f8e92
df7779a
e3f6b99
8792a8c
7ca4bcc
dac1daa
364c3b6
6a8479b
303c9cc
d497e8a
06bbc5b
5e047da
a5059e6
71346a1
fe66b93
d2af472
8dc6c6c
4d0aeb2
309b71a
9f561f1
d5a6fda
954a668
853f552
1362e5c
68bd89b
181fbda
9157cf1
f2c6e08
9f20496
e1961d6
8c72a5e
3eaa967
31fcde4
7c3d183
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can definitely generate a balanced
device_map
for pippy exclusively"device_map = "balanced_pippy"
if the current balanced option is not the best for that. However, I think it would be great if the user can use other options like "sequential". I didn't try but what happens when we only fill 2 gpus out of the 4 available (possiblesequential
case) ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought about how to handle the split points.
device_map
with predefined options ("sequential", "balanced_pippy")device_map
. For the custom case, it can be complicated since the user needs to be careful about the order (OrderedDict()) and he needs to attribute the gpu in a sequential manner because of thatsplit_points.append(next(k for k, v in device_map.items() if v == i))
. So that can be quite complicated.List[str]
.I think that 1) is a must. between 2) and 3), I prefer 3) since it is easier for the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed to do 1 and 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice !