Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_deepspeed.py #2350

Closed

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Locally, all the tests pass when I run the below command:
python -m pytest -s -v ./tests/deepspeed ./tests/fsdp

...

================================================================ 35 passed, 16 warnings in 987.43s (0:16:27) ================================================================

  1. On CI though, a test fails https://github.com/huggingface/accelerate/actions/runs/7564405399/job/20598449339. this PR lower the threshold for that test till we figure out what's happening on the CI runners.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, perhaps a comment can be included as a TODO: Investigate why we can't use performance_lower_bound`? Otherwise merge if happy 🤗

@muellerzr
Copy link
Collaborator

#2353 will fix this directly, can't do deepspeed if we don't have mpy4pi sometimes 😓

@pacman100 pacman100 closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants