add_hook_to_module and remove_hook_from_module compatibility with fx.GraphModule
#2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
approved these changes
Jan 22, 2024
tests/test_hooks.py
Outdated
Comment on lines
369
to
390
| linear2_node = None | ||
| for node in graph_model.graph.nodes: | ||
| if node.name == "linear2": | ||
| linear2_node = node | ||
|
|
||
| self.assertTrue(linear2_node is not None) | ||
|
|
||
| graph_model.graph.inserting_after(linear2_node) | ||
| new_node = graph_model.graph.create_node( | ||
| op="call_function", target=torch.sigmoid, args=(linear2_node,), name="relu" | ||
| ) | ||
|
|
||
| output_node = None | ||
| for node in graph_model.graph.nodes: | ||
| if node.name == "output": | ||
| output_node = node | ||
| self.assertTrue(output_node is not None) | ||
|
|
||
| output_node.replace_input_with(linear2_node, new_node) | ||
|
|
||
| graph_model.graph.lint() | ||
| graph_model.recompile() |
There was a problem hiding this comment.
Could you describe a little bit what we are doing here ?
There was a problem hiding this comment.
Added a comment, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to be illegal to modify the forward method of a
GraphModuleImplinstance, PyTorch rather favors modifying the class method (https://github.com/pytorch/pytorch/blob/c3780010a58a84920335296ee5f091a0db18259f/torch/fx/graph_module.py#L708-L723) though it is unclear why the behavior would be different.Just modifying the class instance forward method results in a frozen forward call - despite modifying the graph (as in the test).
@Giuseppe5 and @nickfraser found this bug. cc @jamesr66a as this was quite a tricky one.