Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address PIP-632 deprecation of distutils #2388

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

AieatAssam
Copy link
Contributor

What does this PR do?

PEP-632 deprecated use of distutils, which are now completely removed in Python 3.12+. environment.py still uses distutils.spawn to detect full path of nvidia-smi executable for GPU detection.
This PR replaces deprecated distutils.spawn with supported shutils.which to ensure conpatibility with Python 3.12+
Code path impacted is windows-only and requires Nvidia GPU, so not a good candidate for automated tests.

Fixes #2379

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@muellerzr

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@muellerzr muellerzr merged commit 3d8b998 into huggingface:main Jan 31, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 distutils deprecation error
3 participants