Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pippy examples over and run tests #2424

Merged
merged 6 commits into from
Feb 9, 2024
Merged

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Since pippy 0.2.0 is out, adds it as a test dep. Also migrates the examples from the example repo to Accelerate and updates the relevant docs.

Should be merged after #2423

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc @kwen2501

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests ! Just a few nits

docs/source/usage_guides/distributed_inference.md Outdated Show resolved Hide resolved
examples/inference/README.md Outdated Show resolved Hide resolved
examples/inference/README.md Outdated Show resolved Hide resolved
examples/inference/README.md Show resolved Hide resolved
examples/inference/bert.py Outdated Show resolved Hide resolved
examples/inference/gpt2.py Outdated Show resolved Hide resolved
examples/inference/llama.py Outdated Show resolved Hide resolved
examples/inference/t5.py Outdated Show resolved Hide resolved
Copy link

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for preparing those examples!
Looks clean and nice!

examples/inference/bert.py Show resolved Hide resolved
examples/inference/gpt2.py Show resolved Hide resolved
examples/inference/t5.py Show resolved Hide resolved
@muellerzr muellerzr merged commit c3aec59 into main Feb 9, 2024
15 of 17 checks passed
@muellerzr muellerzr deleted the migrate-pippy-examples branch February 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants