Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When running
make test
on XPUs, I got the following test results:The failed reason for these 2 tests is the same: XPU hasn't implemented
torch.xpu.amp.GradScaler
yet and in the current logic,self.scaler
will be set totorch.cuda.amp.GradScaler
as shown here.To make the tests pass on XPU devices, we should skip these 2 tests on XPUs.
In addition to that, I noticed that there is no
require_npu
function in thetesting.py
. So I added it to the patch.I am not sure whether it would be better to just use
require_cuda
instead of the combi ofrequire_non_cpu
andrequire_non_xpu
. My goal is just to make all these tests work on XPU. Please let me know your thoughts. And if this patch is too small, just let me know as well. I can think about more tests related to XPU. Thanks a lot!@muellerzr