Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default nccl timeout to 600s issue #2703 #2706

Closed
wants to merge 2 commits into from

Conversation

jubueche
Copy link
Contributor

What does this PR do?

Fixes #2703

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • [X ] Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
    Discussed here.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's be a bit more thorough though please :)

src/accelerate/utils/dataclasses.py Outdated Show resolved Hide resolved
Co-authored-by: Zach Mueller <muellerzr@gmail.com>
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with @muellerzr comments. We could potentially add a description for timeout since I feel time timeout is used a lot and now it is kind of complicated since the default value depends on the backend.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@SunMarc
Copy link
Member

SunMarc commented May 24, 2024

Closing this PR since the PR above fixes the issue !

@SunMarc SunMarc closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NCCL timeout remains at 600s and does not get updated if 1800s passed when initializing Accelerator
3 participants