Add packaging to requirements #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgugger
reviewed
May 25, 2022
setup.py
Outdated
| @@ -55,7 +55,7 @@ | |||
| ] | |||
| }, | |||
| python_requires=">=3.6.0", | |||
| install_requires=["torch>=1.4.0", "pyyaml", "numpy>=1.17"], | |||
| install_requires=["numpy>=1.17", "pyyaml", "torch>=1.4.0", "packaging>=20.0"], | |||
There was a problem hiding this comment.
If we're alphabetically sorting, let's really do it ;-)
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add packaging to the project requirements
What does this add?
This PR adds
packaging>=20.0to the project requirements, which is the same pin as in transformersWho is it for?
Closes #393
Why is it needed?
Current installations from source fail due to the
packagingpackage needing to be installed in both accelerator.py and versions.py in huggingface/accelerate