Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUDA examples tests #407

Merged
merged 4 commits into from
May 31, 2022
Merged

Fix CUDA examples tests #407

merged 4 commits into from
May 31, 2022

Conversation

muellerzr
Copy link
Collaborator

Fix all CUDA and multi-CUDA tests

What does this add?

This PR fixes one of the example tests that would fail due to saving by step and the slight differences between on a single GPU vs multiple GPU's.

Why is it needed?

Currently the example tests will fail when in a multi-gpu, this fixes it.

@muellerzr muellerzr added bug Something isn't working enhancement New feature or request labels May 27, 2022
@muellerzr muellerzr requested a review from sgugger May 27, 2022 17:50
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 27, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to leave just one test_load_states_by_steps that rely on the number of processes to determine which asserts it does and which it does not.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, thanks a lot!

@muellerzr muellerzr merged commit a91575f into main May 31, 2022
@muellerzr muellerzr deleted the fix-tests branch May 31, 2022 13:51
muellerzr added a commit that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants